kou commented on code in PR #48934:
URL: https://github.com/apache/arrow/pull/48934#discussion_r2771834072


##########
dev/release/05-binary-upload.sh:
##########


Review Comment:
   Wow! If we can sign in CI, let's use it!
   
   I think that we need to make MSI reproducible for signing in CI based on 
https://infra.apache.org/release-signing.html#automated-release-signing .
   
   Anyway, let's ask INFRA whether we can sign MSI in CI.
   
   > Do we need to sign the DLL inside the MSI as well or just sign the MSI?
   
   Ah, we may need it... I'm not familiar with Windows security but Windows 
reports a warning for unsigned DLL...?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to