jhorstmann commented on code in PR #9338:
URL: https://github.com/apache/arrow-rs/pull/9338#discussion_r2769237335
##########
arrow-array/src/array/boolean_array.rs:
##########
@@ -520,8 +520,10 @@ impl BooleanArray {
let data = val_builder.as_slice_mut();
let null_slice = null_builder.as_slice_mut();
+ let mut non_nulls = 0usize;
Review Comment:
`NullBuffer::new` already counts the set bits, counting the nulls separately
here could allow the usage of `NullBuffer::new_unchecked`, but I'm not sure
that will really improve performance. I agree that the performance
optimizations should be left to a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
