jhorstmann commented on code in PR #9338:
URL: https://github.com/apache/arrow-rs/pull/9338#discussion_r2769267326
##########
arrow-string/src/regexp.rs:
##########
@@ -180,7 +180,6 @@ pub fn regexp_is_match_scalar<'a, S>(
where
&'a S: StringArrayType<'a>,
{
- let null_bit_buffer = array.nulls().map(|x| x.inner().sliced());
Review Comment:
`sliced` should not be needed now, but its also safe to leave it in. I doubt
we could show any performance impact in a benchmark since regex matching would
be significantly slower than bit slicing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
