liamzwbao commented on code in PR #9338:
URL: https://github.com/apache/arrow-rs/pull/9338#discussion_r2761914547
##########
arrow-array/src/array/boolean_array.rs:
##########
@@ -520,8 +520,10 @@ impl BooleanArray {
let data = val_builder.as_slice_mut();
let null_slice = null_builder.as_slice_mut();
+ let mut non_nulls = 0usize;
Review Comment:
`null_builder` is just a `MutableBuffer`, so it doesn’t carry validity
metadata we can get directly.
In terms of `NullBufferBuilder`, it’s not obvious it would outperform this
approach. We could evaluate it with a benchmark in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
