sdf-jkl commented on PR #9518:
URL: https://github.com/apache/arrow-rs/pull/9518#issuecomment-4008269775
The test error was caused by:
```
thread
'variant_get::test::get_variant_perfectly_shredded_time_as_time32_second'
(3372) panicked at parquet-variant-compute/src/type_conversion.rs:97:11:
attempt to multiply with overflow
```
the line here:
```rust
impl_primitive_from_variant!(datatypes::Time64MicrosecondType, as_time_utc,
|v| {
Some((v.num_seconds_from_midnight() * 1_000_000 + v.nanosecond() /
1_000) as i64)
});
```
Multiplication happens before casting `v.num_seconds_from_midnight()` or
`v.nanosecond()` to i64 and could cause an overflow.
Fixed in a commit above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
