sdf-jkl commented on code in PR #9518:
URL: https://github.com/apache/arrow-rs/pull/9518#discussion_r2914639575
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -836,22 +814,20 @@ mod test {
macro_rules! perfectly_shredded_variant_array_fn {
($func:ident, $typed_value_gen:expr) => {
fn $func() -> ArrayRef {
- // At the time of writing, the `VariantArrayBuilder` does not
support shredding.
- // so we must construct the array manually. see
https://github.com/apache/arrow-rs/issues/7895
+ // Prefer producing fixtures with shred_variant from
unshredded input.
+ // Fall back for non-shreddable test-only Arrow types (e.g.
LargeUtf8/LargeBinary/Null).
+ let typed_value: ArrayRef = Arc::new($typed_value_gen());
+ if let Ok(unshredded) = cast_to_variant(typed_value.as_ref()) {
Review Comment:
thanks, updated here:
https://github.com/apache/arrow-rs/pull/9518/commits/ff485cdb41c220fee2c80a4a63fd6e56a234ac35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
