sdf-jkl commented on PR #9518: URL: https://github.com/apache/arrow-rs/pull/9518#issuecomment-4032677188
> Thanks for the improvement. Overall looks great to me. I left some minor comments to be considered. > > Another question is whether we need to support shred to `LargeUtf8`/`LargeBinary`, I can only find [this comment](https://github.com/apache/arrow-rs/pull/8600/changes#r2442296788), it seems is _legal_ to support (it may not need to be included in the current pr even if we want to support it) You're right. I found the mention in `shred_variant.rs`. They are not supported here yet, however they are supported by `VariantArray::try_new` and `canonicalize_and_verify_data_type` as mentioned by @friendlymatthew in #9515: https://github.com/apache/arrow-rs/blob/d2e2cdafed93a8e0152fe1d018ec2cef154ccb20/parquet-variant-compute/src/shred_variant.rs#L1147-L1166 I'd add support for these types for `shred_variant` before moving forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
