tadeja commented on code in PR #49491:
URL: https://github.com/apache/arrow/pull/49491#discussion_r2917309223
##########
.github/workflows/cpp.yml:
##########
@@ -230,6 +230,12 @@ jobs:
brew uninstall pkg-config || :
brew uninstall [email protected] || :
brew bundle --file=cpp/Brewfile
+
+ # protobuf@33 is keg-only, so make it visible to CMake and
pkg-config.
+ export PROTOBUF_PREFIX="$(brew --prefix protobuf@33)"
+ echo
"PKG_CONFIG_PATH=${PROTOBUF_PREFIX}/lib/pkgconfig:${PKG_CONFIG_PATH}" >>
"$GITHUB_ENV"
+ echo
"CMAKE_PREFIX_PATH=${PROTOBUF_PREFIX}:${ARROW_HOME}:${CMAKE_PREFIX_PATH}" >>
"$GITHUB_ENV"
+ echo "${PROTOBUF_PREFIX}/bin" >> "$GITHUB_PATH"
Review Comment:
Now there's only [brew
"protobuf@33"](https://github.com/apache/arrow/pull/49491/changes#diff-87eb96363e17dbc9cb816c99123f76f25d63eb48920dd785a486ee59ee1997a1R39)
The conditional shouldn't be required - if someone removed workaround of @33
from Brewfile but forgot to update the workflow then failure should happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
