raulcd commented on code in PR #49491:
URL: https://github.com/apache/arrow/pull/49491#discussion_r2924744701
##########
cpp/src/arrow/engine/substrait/options.cc:
##########
@@ -68,17 +68,35 @@ class DefaultExtensionProvider : public
BaseExtensionProvider {
const ExtensionSet& ext_set) override {
if (rel.Is<substrait_ext::AsOfJoinRel>()) {
substrait_ext::AsOfJoinRel as_of_join_rel;
+#if PROTOBUF_VERSION >= 3015000
Review Comment:
In the case of `Any.UnpackTo` I don't think the ifdef guard is necessary, I
can see that it has been a function that returns a boolean for more than 7
years, just checking really old commits:
https://github.com/protocolbuffers/protobuf/blame/763c3588740b97e8e80b1b1a1a2dc4f417647133/src/google/protobuf/any.pb.h#L119
but we can wait for CI to finish and try to just remove the `ifdef` and just
the change as we did for:
`cpp/src/arrow/flight/transport/grpc/serialization_internal.cc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
