tadeja commented on PR #49491: URL: https://github.com/apache/arrow/pull/49491#issuecomment-4046775113
Ok, @raulcd it's indeed now failing at options.cc too, I am adding similar if-else https://github.com/apache/arrow/actions/runs/23003764617/job/66794807259#step:9:1956 https://github.com/apache/arrow/actions/runs/23003764691/job/66794807733#step:12:2438 ``` [808/1314] Building CXX object src/arrow/engine/CMakeFiles/arrow_substrait_objlib.dir/substrait/options.cc.o FAILED: [code=1] src/arrow/engine/CMakeFiles/arrow_substrait_objlib.dir/substrait/options.cc.o < ... > /Users/runner/work/arrow/arrow/cpp/src/arrow/engine/substrait/options.cc:71:7: error: ignoring return value of function declared with 'nodiscard' attribute [-Werror,-Wunused-result] rel.UnpackTo(&as_of_join_rel); ^~~~~~~~~~~~ ~~~~~~~~~~~~~~~ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
