klion26 commented on code in PR #9599:
URL: https://github.com/apache/arrow-rs/pull/9599#discussion_r2986576483
##########
parquet-variant-compute/src/variant_to_arrow.rs:
##########
@@ -941,7 +942,14 @@ where
match value {
Variant::List(list) => {
for element in list.iter() {
- self.element_builder.append_value(element)?;
+ match element {
Review Comment:
Here, we need to distinguish whether the _element_ is `Variant::Null` or not
because `Variant::Null` can't be cast to any type. Will it be better if we
handle this logic in the following code (test whether the passed in is
`Variant::Null`)
https://github.com/apache/arrow-rs/blob/980ea0b36c79a9e996efd90ad5f24571f0f9c0e0/parquet-variant-compute/src/variant_to_arrow.rs#L709-L724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
