scovich commented on code in PR #9599:
URL: https://github.com/apache/arrow-rs/pull/9599#discussion_r2989897880
##########
parquet-variant-compute/src/variant_to_arrow.rs:
##########
@@ -941,7 +942,14 @@ where
match value {
Variant::List(list) => {
for element in list.iter() {
- self.element_builder.append_value(element)?;
+ match element {
Review Comment:
Yeah, I glanced at that same code yesterday and reached a similar
conclusion. We either need to teach the `$transform` to be a tri-state (e.g.
`Result<Option<...>>`) or the macro needs to handle `Variant::Null` separately,
bypassing the `$transform` entirely. I don't know which one is better, would
need to stare more at the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
