mzabaluev commented on code in PR #9700:
URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3078279639
##########
parquet/src/data_type.rs:
##########
@@ -984,6 +990,10 @@ pub(crate) mod private {
Ok(num_values)
}
+ fn dict_encoding_size(&self) -> usize {
+ 12
Review Comment:
OK, the array alignment is nailed down in the spec, but `Int96` wrapping the
array is a struct with a Rust repr, so... 🤷 Could be a case for declaring the
struct with `repr(packed)`, but I'd rather argue we use explicit numbers here
because the encoding is not a straight memory copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
