etseidl commented on code in PR #9700:
URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3096771512
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -582,7 +603,15 @@ where
}
match &mut encoder.dict_encoder {
- Some(dict_encoder) => dict_encoder.encode(values, indices),
+ Some(dict_encoder) => {
+ dict_encoder.encode(values, indices);
+ if let Some(counter) = encoder.plain_data_size_counter.as_mut() {
+ for idx in indices {
Review Comment:
> I had a mind to keep comparing after every encoded data page, for cases
when the configured minimal sample is still not indicative of the overall value
distribution and the efficiency degrades somewhere farther down the page chunk.
Fair...but then perhaps the size limit will catch it. In any event, we
should stop collectin after we have actually fallen back 😉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
