mzabaluev commented on code in PR #9700:
URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3099650466
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -582,7 +603,15 @@ where
}
match &mut encoder.dict_encoder {
- Some(dict_encoder) => dict_encoder.encode(values, indices),
+ Some(dict_encoder) => {
+ dict_encoder.encode(values, indices);
+ if let Some(counter) = encoder.plain_data_size_counter.as_mut() {
+ for idx in indices {
Review Comment:
> we should stop collectin after we have actually fallen back 😉
That's already the case, with the `plain_data_size_counter` member set to
`None` in both `flush_dict_page` implementations, and the collecting is also
not happening in the put methods in case there is no dictionary. Though if I
implement a fix for #9739, this may need to be refactored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
