mzabaluev commented on code in PR #9700:
URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3096508954
##########
parquet/src/arrow/arrow_writer/byte_array.rs:
##########
@@ -582,7 +603,15 @@ where
}
match &mut encoder.dict_encoder {
- Some(dict_encoder) => dict_encoder.encode(values, indices),
+ Some(dict_encoder) => {
+ dict_encoder.encode(values, indices);
+ if let Some(counter) = encoder.plain_data_size_counter.as_mut() {
+ for idx in indices {
Review Comment:
I had a mind to keep comparing after every encoded data page, for cases when
the configured minimal sample is still not indicative of the overall value
distribution and the efficiency degrades somewhere farther down the page chunk.
But I understand the concern. Since this behavior is tunable per column through
the writer API, I think it's OK to cut counting. For consistency, this should
be also done in the generic encoder, I assume?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
