AntoinePrv commented on code in PR #49756:
URL: https://github.com/apache/arrow/pull/49756#discussion_r3118848582
##########
cpp/src/arrow/util/bpacking.cc:
##########
@@ -33,16 +33,26 @@ struct UnpackDynamicFunction {
static constexpr auto implementations() {
return std::array{
+ // x86 implementations
#if defined(ARROW_HAVE_SSE4_2)
Implementation{DispatchLevel::NONE, &bpacking::unpack_sse4_2<Uint>},
-#else
- Implementation{DispatchLevel::NONE, &bpacking::unpack_scalar<Uint>},
-#endif
-#if defined(ARROW_HAVE_RUNTIME_AVX2)
+# if defined(ARROW_HAVE_RUNTIME_AVX2)
Implementation{DispatchLevel::AVX2, &bpacking::unpack_avx2<Uint>},
-#endif
-#if defined(ARROW_HAVE_RUNTIME_AVX512)
+# endif
+# if defined(ARROW_HAVE_RUNTIME_AVX512)
Implementation{DispatchLevel::AVX512, &bpacking::unpack_avx512<Uint>},
+# endif
+
+ // ARM implementations
+#elif defined(ARROW_HAVE_NEON)
+ Implementation{DispatchLevel::NONE, &bpacking::unpack_neon<Uint>},
+# if defined(ARROW_HAVE_RUNTIME_SVE256)
Review Comment:
**TODO**
A mistake (benchmarks actually run the functions directly without going
through the dynamic dispatch).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
