AntoinePrv commented on code in PR #49756:
URL: https://github.com/apache/arrow/pull/49756#discussion_r3118864055


##########
cpp/src/arrow/util/bpacking_simd_128.cc:
##########
@@ -17,8 +17,10 @@
 
 #if defined(ARROW_HAVE_NEON)
 #  define UNPACK_PLATFORM unpack_neon

Review Comment:
   Possibly, though I thought it best that the macro is `#undef` at the end of 
the header (making it useless here).
   We can make it more explicit (`ARROW_BPACKING_UNPACK_ARCH128`) an not 
undefining it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to