AntoinePrv commented on code in PR #49756:
URL: https://github.com/apache/arrow/pull/49756#discussion_r3118895513
##########
cpp/src/arrow/util/bpacking_simd_128.cc:
##########
@@ -30,11 +32,11 @@
namespace arrow::internal::bpacking {
template <typename UnpackedUint, int kPackedBitSize>
-using Simd128Kernel = Kernel<UnpackedUint, kPackedBitSize, 128>;
+using KERNEL_PLATFORM = Kernel<UnpackedUint, kPackedBitSize,
xsimd::default_arch>;
Review Comment:
Unfortunately we cannot because this alias needs to be parameterized by
types (this is a requirement from unpack_jump) and this is not possible inside
a function.
As for the different names for `KERNEL_PLATFORM`, this is a better safe than
sorry ODR violation prevention. Although perhaps we could do better with inline
namespaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
