mzabaluev commented on code in PR #9700:
URL: https://github.com/apache/arrow-rs/pull/9700#discussion_r3119008658


##########
parquet/src/data_type.rs:
##########
@@ -803,6 +804,10 @@ pub(crate) mod private {
             Ok(values_read)
         }
 
+        fn plain_encoded_size(&self) -> usize {
+            panic!("Dictionary encoding should not be used for BOOLEAN type")
+        }

Review Comment:
   Good catch. This is a bit tricky though, since booleans are always 
bit-packed, so the returned size in bytes for a single value will be bogus.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to