lriggs commented on code in PR #49879:
URL: https://github.com/apache/arrow/pull/49879#discussion_r3165003270
##########
cpp/src/gandiva/regex_util.cc:
##########
@@ -23,16 +23,16 @@ const std::set<char> RegexUtil::pcre_regex_specials_ = {
'[', ']', '(', ')', '|', '^', '-', '+', '*', '?', '{', '}', '$', '\\',
'.'};
Status RegexUtil::SqlLikePatternToPcre(const std::string& sql_pattern, char
escape_char,
- std::string& pcre_pattern) {
+ std::string* pcre_pattern) {
/// Characters that are considered special by pcre regex. These needs to be
Review Comment:
I think you should check for null now that its possible to pass a null
pointer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
