kou commented on code in PR #49879:
URL: https://github.com/apache/arrow/pull/49879#discussion_r3167105660
##########
cpp/src/gandiva/regex_util.h:
##########
@@ -31,10 +31,10 @@ class GANDIVA_EXPORT RegexUtil {
public:
// Convert an sql pattern to a pcre pattern
static Status SqlLikePatternToPcre(const std::string& like_pattern, char
escape_char,
- std::string& pcre_pattern);
+ std::string* pcre_pattern);
Review Comment:
The former. If we use `arrow::Result<std::string>`, we don't need most
changes in this PR. So I feel that the follow-up PR style isn't suitable for
this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
