Reranko05 commented on code in PR #49879:
URL: https://github.com/apache/arrow/pull/49879#discussion_r3165586837
##########
cpp/src/gandiva/regex_util.h:
##########
@@ -31,10 +31,10 @@ class GANDIVA_EXPORT RegexUtil {
public:
// Convert an sql pattern to a pcre pattern
static Status SqlLikePatternToPcre(const std::string& like_pattern, char
escape_char,
- std::string& pcre_pattern);
+ std::string* pcre_pattern);
Review Comment:
Thanks for the suggestion! Since this PR is scoped to address the mutable
out argument pattern in RegexUtil as part of GH-19667, I kept the change
minimal.
Would you prefer extending this PR to use `arrow::Result<std::string>`, or
opening a follow-up PR for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
