Rich-T-kid commented on code in PR #9936:
URL: https://github.com/apache/arrow-rs/pull/9936#discussion_r3242936421
##########
parquet/benches/arrow_writer.rs:
##########
@@ -363,8 +384,10 @@ fn write_batch_with_option(
bench.iter(|| {
let mut file = Empty::default();
- let mut writer =
- ArrowWriter::try_new(&mut file, batch.schema(),
Some(props.clone())).unwrap();
+ let Ok(mut writer) = ArrowWriter::try_new(&mut file, batch.schema(),
Some(props.clone()))
Review Comment:
This approach adds no overhead for the regular (non-ree) branches since
unwrap should boil down to the same machine code as this expression. the issue
is this doesn't allow for errors to be propagated for other reasons. this
shouldnt be an issue for existing benchmarks since they all run fine with no
issues. is there another way to go about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
