Rich-T-kid commented on code in PR #9936:
URL: https://github.com/apache/arrow-rs/pull/9936#discussion_r3243296413
##########
parquet/benches/arrow_writer.rs:
##########
@@ -401,6 +424,9 @@ fn create_batches() -> Vec<(&'static str, RecordBatch)> {
let batch = create_string_bench_batch_non_null(BATCH_SIZE, 0.25,
0.75).unwrap();
batches.push(("string_non_null", batch));
+ let batch = create_string_ree_bench_batch(BATCH_SIZE, 0.25, 0.75).unwrap();
Review Comment:
maybe other types can be added? other primitive types such as [int,float] as
well as writing out nested types like [list,struct,ree over ree]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
