Rich-T-kid commented on code in PR #9936:
URL: https://github.com/apache/arrow-rs/pull/9936#discussion_r3294900501
##########
parquet/benches/arrow_writer.rs:
##########
@@ -363,8 +384,10 @@ fn write_batch_with_option(
bench.iter(|| {
let mut file = Empty::default();
- let mut writer =
- ArrowWriter::try_new(&mut file, batch.schema(),
Some(props.clone())).unwrap();
+ let Ok(mut writer) = ArrowWriter::try_new(&mut file, batch.schema(),
Some(props.clone()))
Review Comment:
This PR is to introduce benchmarks for
https://github.com/apache/arrow-rs/issues/8016 , so that we can [gauge the
performance](https://github.com/apache/arrow-rs/issues/8016#issuecomment-4390890656)
of changes as they happen. I thought I'd make sense to make it a separate PR
since it can be isolated from the write logic & would be easier to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
