sdf-jkl commented on code in PR #9965:
URL: https://github.com/apache/arrow-rs/pull/9965#discussion_r3271031884


##########
arrow-arith/src/temporal.rs:
##########
@@ -118,6 +117,8 @@ impl FromStr for DatePart {
             "isoweek" => Self::WeekISO,
             "d" | "day" | "days" => Self::Day,
             "dow" | "dayofweek" => Self::DayOfWeekSunday0,
+            "dayofweek1" => Self::DayOfWeekSunday1,

Review Comment:
   Yeah, I'll take a look at similar enums in other projects. The reason to add 
it here is for upstream DataFusion Spark temporal function support. 
   
   `sparkdow`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to