sdf-jkl commented on code in PR #9965:
URL: https://github.com/apache/arrow-rs/pull/9965#discussion_r3293095512
##########
arrow-arith/src/temporal.rs:
##########
@@ -118,6 +117,8 @@ impl FromStr for DatePart {
"isoweek" => Self::WeekISO,
"d" | "day" | "days" => Self::Day,
"dow" | "dayofweek" => Self::DayOfWeekSunday0,
+ "dayofweek1" => Self::DayOfWeekSunday1,
Review Comment:
Oh right, thanks for catching this. I think it's better to expose it than
not. It'd make the arguments more parallel.
What do you think about:
```
DayOfWeekMonday0 -> isodow0
DayOfWeekMonday1 -> isodow
DayOfWeekSunday0 -> dow
DayOfWeekSunday1 -> dow1
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
