Jefffrey commented on code in PR #9965:
URL: https://github.com/apache/arrow-rs/pull/9965#discussion_r3292045104
##########
arrow-arith/src/temporal.rs:
##########
@@ -118,6 +117,8 @@ impl FromStr for DatePart {
"isoweek" => Self::WeekISO,
"d" | "day" | "days" => Self::Day,
"dow" | "dayofweek" => Self::DayOfWeekSunday0,
+ "dayofweek1" => Self::DayOfWeekSunday1,
Review Comment:
I suppose if we step away from thinking in SQL terms it makes sense to be
able to reach the `DayOfWeekSunday1` variant from a string representation, so
we can have this `dayofweek1`. Though it does leave the question of if we
should similarly expose `DayOfWeekMonday0`, since that is unreachable via
string parsing 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
