Karakatiza666 commented on code in PR #438:
URL: https://github.com/apache/arrow-js/pull/438#discussion_r3279817128
##########
src/visitor/jsonvectorassembler.ts:
##########
@@ -152,6 +153,12 @@ export class JSONVectorAssembler extends Visitor {
'children': this.visitMany(data.type.children, data.children)
};
}
+ public visitLargeList<T extends LargeList>(data: Data<T>) {
+ return {
+ 'OFFSET': [...bigNumsToStrings(data.valueOffsets, 2)],
Review Comment:
This bug is unrelated to this PR and does not block it; it also affects
multiple other types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
