Karakatiza666 commented on code in PR #438:
URL: https://github.com/apache/arrow-js/pull/438#discussion_r3285911209
##########
src/visitor/vectorassembler.ts:
##########
@@ -234,11 +235,12 @@ function assembleBinaryViewVector<T extends BinaryView |
Utf8View>(this: VectorA
}
/** @ignore */
-function assembleListVector<T extends Map_ | List | FixedSizeList>(this:
VectorAssembler, data: Data<T>) {
+function assembleListVector<T extends Map_ | List | LargeList |
FixedSizeList>(this: VectorAssembler, data: Data<T>) {
const { length, valueOffsets } = data;
- // If we have valueOffsets (MapVector, ListVector), push that buffer first
+ // If we have valueOffsets (MapVector, ListVector, LargeListVector), push
that buffer first
if (valueOffsets) {
- const { [0]: begin, [length]: end } = valueOffsets;
+ const begin = bigIntToNumber(valueOffsets[0]);
+ const end = bigIntToNumber(valueOffsets[length]);
Review Comment:
There are multiple 64bit - based types for which the same tradeoff is
applied. I'll comment on details in a bit, but preliminarly adding true 64-bit
indexing is a much larger scope, and would apply to more than just LargeList.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
