Karakatiza666 commented on PR #438: URL: https://github.com/apache/arrow-js/pull/438#issuecomment-4512368131
@GeorgeLeePatterson , thanks for the pointer! Unless you mean something else, slicing is covered by `validateVector`, run from `test/unit/generated-data-tests.ts`. Addressed other points. Also, I caught I missed a case for `typeFromJSON` in `src/ipc/metadata/json.ts`, and one in `src/visitor/typector.ts`. The only relevant thing in #325 that was missing here was the change in `typector.ts`. Otherwise this PR looks like a superset of #325 in terms of LargeList implementation; this PR does not include extra LargeListView tests or other *ListView additions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
