kylebarron commented on code in PR #724:
URL:
https://github.com/apache/arrow-rs-object-store/pull/724#discussion_r3342155266
##########
Cargo.toml:
##########
@@ -82,12 +82,18 @@ futures-channel = {version = "0.3", features = ["sink"]}
[features]
default = ["fs"]
-cloud = ["serde", "serde_json", "quick-xml", "hyper", "reqwest",
"reqwest/stream", "chrono/serde", "base64", "rand", "ring", "http-body-util",
"form_urlencoded", "serde_urlencoded", "tokio"]
-azure = ["cloud", "httparse"]
+cloud = ["cloud-base", "reqwest"]
Review Comment:
Should we discuss feature naming? Either now or in an issue before the next
release? Because now `cloud` is an alias for `reqwest`, essentially. Would it
read clearer if say `azure` was defined as
```diff
- azure = ["azure-base", "cloud"]
+ azure = ["azure-base", "reqwest"]
```
because `azure-base` already depends on `cloud-base`. We have a diamond
dependency graph here.
Should we have some docs about feature flag options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
