awesterb commented on code in PR #724:
URL:
https://github.com/apache/arrow-rs-object-store/pull/724#discussion_r3388015903
##########
Cargo.toml:
##########
@@ -82,12 +82,18 @@ futures-channel = {version = "0.3", features = ["sink"]}
[features]
default = ["fs"]
-cloud = ["serde", "serde_json", "quick-xml", "hyper", "reqwest",
"reqwest/stream", "chrono/serde", "base64", "rand", "ring", "http-body-util",
"form_urlencoded", "serde_urlencoded", "tokio"]
-azure = ["cloud", "httparse"]
+cloud = ["cloud-base", "reqwest"]
Review Comment:
Renaming `-custom` to `-base` is completely fine by me too. (Though it
might read a bit odd in the `object_store` code: custom is not an additional
feature.)
I agree the `cloud` adds nothing to `reqwest`. It is only there for
backwards compatibility. If you want to make this a breaking change it can be
removed, of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
