kevinjqliu commented on code in PR #724:
URL:
https://github.com/apache/arrow-rs-object-store/pull/724#discussion_r3382450414
##########
Cargo.toml:
##########
@@ -82,12 +82,18 @@ futures-channel = {version = "0.3", features = ["sink"]}
[features]
default = ["fs"]
-cloud = ["serde", "serde_json", "quick-xml", "hyper", "reqwest",
"reqwest/stream", "chrono/serde", "base64", "rand", "ring", "http-body-util",
"form_urlencoded", "serde_urlencoded", "tokio"]
-azure = ["cloud", "httparse"]
+cloud = ["cloud-base", "reqwest"]
Review Comment:
+1 we'd want to coordinate on naming since #707 is also renaming these
features.
Also see
https://github.com/apache/arrow-rs-object-store/pull/707#pullrequestreview-4460657534
both `-base` and `-custom` makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
