Tpt commented on code in PR #707:
URL:
https://github.com/apache/arrow-rs-object-store/pull/707#discussion_r3397221598
##########
Cargo.toml:
##########
@@ -82,13 +83,26 @@ futures-channel = {version = "0.3", features = ["sink"]}
[features]
default = ["fs"]
-cloud = ["serde", "serde_json", "quick-xml", "hyper", "reqwest",
"reqwest/stream", "chrono/serde", "base64", "rand", "ring", "http-body-util",
"form_urlencoded", "serde_urlencoded", "tokio"]
-azure = ["cloud", "httparse"]
+cloud-no-crypto = ["serde", "serde_json", "quick-xml", "hyper", "reqwest",
"reqwest/stream", "chrono/serde", "base64", "rand","http-body-util",
"form_urlencoded", "serde_urlencoded", "tokio"]
Review Comment:
> The remaining compatibility/default decision is whether the
batteries-included features should keep ring as the default crypto provider for
compatibility, or intentionally switch to aws-lc-rs.
My suggestion would be to follow `reqwest` and use `aws-lc-rs`. This way
users of both `object_store` and `reqwest` do not end up with two crypto stacks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
