alamb commented on PR #707: URL: https://github.com/apache/arrow-rs-object-store/pull/707#issuecomment-4712451239
Ok, I merged up from main and did some polishing. I think this PR is now almost ready as it could be, though there are some non trivial gaps. I suggest we merge the PR as is, and then address the gaps as a follow on: ## fix testing gaps - Custom CryptoProvider / `crypto_provider` is entirely untested. - NoSystemCertificates not in the config round-trip test. client_test_config_from_map (src/client/mod.rs:1107) enumerates the other keys but omits the new one, so its parse→serialize round-trip and with_no_system_certificates are untested. ## No documentation Docs say we support a custom provider but show no example. "You can also implement a custom client::CryptoProvider" with no example. Ideally we would document this via, a doctest. However, I don't think either of those things would block the release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
