kevinjqliu commented on code in PR #707:
URL:
https://github.com/apache/arrow-rs-object-store/pull/707#discussion_r3423172546
##########
Cargo.toml:
##########
@@ -84,29 +85,33 @@ futures-channel = {version = "0.3", features = ["sink"]}
default = ["fs"]
# Shared cloud/provider implementation dependencies.
-# This intentionally does NOT include reqwest.
-cloud-base = ["serde", "serde_json", "quick-xml", "hyper", "chrono/serde",
"base64", "rand", "ring", "http-body-util", "form_urlencoded",
"serde_urlencoded", "tokio"]
+# This intentionally does NOT include reqwest or a bundled crypto provider.
+cloud-base = ["serde", "serde_json", "quick-xml", "hyper", "chrono/serde",
"base64", "rand", "http-body-util", "form_urlencoded", "serde_urlencoded",
"tokio"]
# Built-in reqwest-based HTTP transport.
reqwest = ["dep:reqwest", "reqwest/stream"]
-# Provider base features.
-# These compile provider logic without forcing reqwest.
+# Bundled crypto providers.
+# Selecting one provides the default `CryptoProvider`; otherwise a custom
+# provider must be supplied at runtime.
+aws-lc-rs = ["dep:aws-lc-rs", "rustls-pki-types"]
+ring = ["dep:ring", "rustls-pki-types"]
+
+# Implementation base features.
+# These compile provider logic without forcing reqwest or a crypto provider.
azure-base = ["cloud-base", "httparse"]
-gcp-base = ["cloud-base", "rustls-pki-types"]
+gcp-base = ["cloud-base"]
aws-base = ["cloud-base", "crc-fast", "md-5"]
http-base = ["cloud-base"]
-# Batteries-included provider features.
-# These preserve existing behavior: enabling aws/azure/gcp/http gives
-# the default reqwest transport.
-azure = ["azure-base", "reqwest"]
-gcp = ["gcp-base", "reqwest"]
-aws = ["aws-base", "reqwest"]
-http = ["http-base", "reqwest"]
+# "Batteries-included" implementation features.
+# Each enables the default `reqwest` transport (with rustls) and `aws-lc-rs`
+azure = ["azure-base", "reqwest", "reqwest/rustls", "aws-lc-rs"]
+gcp = ["gcp-base", "reqwest", "reqwest/rustls", "aws-lc-rs"]
+aws = ["aws-base", "reqwest", "reqwest/rustls", "aws-lc-rs"]
+http = ["http-base", "reqwest", "reqwest/rustls", "aws-lc-rs"]
fs = ["walkdir", "tokio", "nix", "windows-sys"]
-tls-webpki-roots = ["reqwest?/rustls-tls-webpki-roots"]
Review Comment:
👍 looks like `rustls-tls-webpki-roots` was removed in `reqwest` 0.13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
