kevinjqliu commented on PR #724:
URL:
https://github.com/apache/arrow-rs-object-store/pull/724#issuecomment-4685144311
Thanks everyone! Glad we found a way to move forward with this.
I did a brief review, it looks great directionally.
One related question: should we also add a small CI check that asserts the
dependency contract directly, i.e. that the `*-base` features do not pull in
`reqwest` at all? Maybe we could add one lightweight check for the combined
base-feature case, something like:
```bash
cargo tree \
--no-default-features \
--features aws-base,azure-base,gcp-base,http-base \
--edges normal \
-i reqwest
```
and fail CI if `reqwest` is present.
Not a blocker, but if `*-base` is meant to be a supported “no reqwest”
contract, this seems like a useful guardrail against accidentally reintroducing
it in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
