kevinjqliu commented on code in PR #724:
URL:
https://github.com/apache/arrow-rs-object-store/pull/724#discussion_r3399476082
##########
.github/workflows/ci.yml:
##########
@@ -57,6 +57,14 @@ jobs:
run: cargo clippy --features azure -- -D warnings
- name: Run clippy with http feature
run: cargo clippy --features http -- -D warnings
+ - name: Run clippy with aws-base feature
+ run: cargo clippy --no-default-features --features aws-base -- -D
warnings
+ - name: Run clippy with azure-base feature
+ run: cargo clippy --no-default-features --features azure-base -- -D
warnings
+ - name: Run clippy with gcp-base feature
+ run: cargo clippy --no-default-features --features gcp-base -- -D
warnings
+ - name: Run clippy with http-base feature
+ run: cargo clippy --no-default-features --features http-base -- -D
warnings
Review Comment:
```suggestion
run: cargo clippy --no-default-features --features http-base -- -D
warnings
- name: Verify base features do not enable reqwest
run: |
if cargo tree \
--no-default-features \
--features aws-base,azure-base,gcp-base,http-base \
--edges normal \
--prefix none \
-f '{p}' \
| grep -E '^reqwest v'; then
echo "reqwest must not be enabled by *-base features"
exit 1
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
