kevinjqliu commented on code in PR #724:
URL:
https://github.com/apache/arrow-rs-object-store/pull/724#discussion_r3399237618
##########
Cargo.toml:
##########
@@ -82,12 +82,18 @@ futures-channel = {version = "0.3", features = ["sink"]}
[features]
default = ["fs"]
-cloud = ["serde", "serde_json", "quick-xml", "hyper", "reqwest",
"reqwest/stream", "chrono/serde", "base64", "rand", "ring", "http-body-util",
"form_urlencoded", "serde_urlencoded", "tokio"]
-azure = ["cloud", "httparse"]
+cloud = ["cloud-base", "reqwest"]
+cloud-base = ["serde", "serde_json", "quick-xml", "hyper", "chrono/serde",
"base64", "rand", "ring", "http-body-util", "form_urlencoded",
"serde_urlencoded", "tokio"]
Review Comment:
nit: do you think its helpful to include some comments to explain why the
features are structured this way?
```
# Shared cloud/provider implementation dependencies.
# This intentionally does NOT include reqwest.
cloud-base = [...]
# Built-in reqwest-based HTTP transport.
reqwest = [
"dep:reqwest",
"reqwest/stream",
]
# Compatibility/convenience alias.
# Historically, cloud meant "common cloud support", including reqwest.
# Keep that behavior for existing users.
cloud = [...]
# Provider base features.
# These compile provider logic without forcing reqwest.
azure-base = [...]
gcp-base = [...]
aws-base = [...]
http-base = [...]
# Batteries-included provider features.
# These preserve existing behavior: enabling aws/azure/gcp/http gives
# the default reqwest transport.
azure = [...]
gcp = [...]
aws = [...]
http = [...]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
