wgtmac commented on code in PR #50157:
URL: https://github.com/apache/arrow/pull/50157#discussion_r3412585057
##########
cpp/src/parquet/thrift_internal.h:
##########
@@ -290,6 +297,14 @@ static inline EncodedStatistics FromThrift(const
format::Statistics& stats) {
return out;
}
+static inline EncodedStatistics FromThrift(const format::Statistics& stats) {
Review Comment:
This overload is still used when decoding page header statistics, where the
current call path does not have a ColumnDescriptor. The descriptor-aware
overload is now used for column chunk metadata, while this overload
intentionally preserves the previous best-effort behavior for descriptor-less
callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
