Copilot commented on code in PR #50157:
URL: https://github.com/apache/arrow/pull/50157#discussion_r3413491041
##########
cpp/src/parquet/metadata_test.cc:
##########
@@ -275,6 +275,104 @@ TEST(Metadata, TestBuildAccess) {
ASSERT_TRUE(f_accessor_1->Equals(*f_accessor->Subset({2, 0})));
}
+namespace {
+
+std::string EncodeInt32(int32_t value) {
+ return std::string(reinterpret_cast<const char*>(&value), sizeof(value));
+}
Review Comment:
EncodeInt32() currently serializes using native endianness (reinterpret_cast
of int32_t). Parquet INT32 values in statistics are encoded little-endian, so
this test can fail on big-endian platforms. Convert to little-endian before
creating the byte string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
