amoeba commented on code in PR #4402:
URL: https://github.com/apache/arrow-adbc/pull/4402#discussion_r3422311848
##########
ruby/lib/adbc/database.rb:
##########
@@ -18,13 +18,20 @@
module ADBC
class Database
class << self
- def open(**options)
+ def new
+ database = super
+ database.set_load_flags(LoadFlags::DEFAULT)
+ database
+ end
Review Comment:
ah, thanks. I originally override initialize like,
```ruby
module ADBC
class Database
def initialize
super
set_load_flags(LoadFlags::DEFAULT)
end
end
end
```
and the `set_load_flags` was failing with "database already released" so I
think that's not doing what I thought it was. The approach with `new` fixed it.
Setting load_flags in GLib looks better so I'll do that. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
