kou commented on code in PR #4402:
URL: https://github.com/apache/arrow-adbc/pull/4402#discussion_r3424220711
##########
ruby/lib/adbc/database.rb:
##########
@@ -18,13 +18,20 @@
module ADBC
class Database
class << self
- def open(**options)
+ def new
+ database = super
+ database.set_load_flags(LoadFlags::DEFAULT)
+ database
+ end
Review Comment:
Ah, we need to call the original `initialize` instead of `super` because
`Database#initialize` is already defined (and this is not inherited class):
```ruby
module ADBC
class Database
alias_method :initialize_raw, :initialize
def initialize
initialize_raw
set_load_flags(LoadFlags::DEFAULT)
end
end
end
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
