amoeba commented on code in PR #4402:
URL: https://github.com/apache/arrow-adbc/pull/4402#discussion_r3422423646
##########
ruby/lib/adbc/database.rb:
##########
@@ -18,13 +18,20 @@
module ADBC
class Database
class << self
- def open(**options)
+ def new
+ database = super
+ database.set_load_flags(LoadFlags::DEFAULT)
+ database
+ end
+
+ def open(load_flags: nil, **options)
database = new
need_release = true
begin
options.each do |key, value|
- database.set_option(key, value)
+ database.set_option(key.to_s, value)
Review Comment:
I tested and no. It looks like gobject can handle the coercion. Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
