kevinjqliu commented on code in PR #758:
URL:
https://github.com/apache/arrow-rs-object-store/pull/758#discussion_r3431209157
##########
src/local.rs:
##########
@@ -524,7 +513,10 @@ impl ObjectStore for LocalFileSystem {
let config = Arc::clone(&config);
maybe_spawn_blocking(move || {
let location = location?;
- Self::delete_location(config, automatic_cleanup,
&location)?;
+ // Do not apply `with_fsync` to standalone deletes.
+ // Use `fsync=true` only when removing the source after a
synced copy in
+ // `rename_if_not_exists`.
Review Comment:
```suggestion
// `with_fsync` does not apply to standalone deletes;
only create-mode rename
// fsyncs its internal source removal as part of the
durable copy-and-delete.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
