alamb commented on code in PR #758:
URL:
https://github.com/apache/arrow-rs-object-store/pull/758#discussion_r3435099305
##########
src/local.rs:
##########
@@ -513,7 +513,7 @@ impl ObjectStore for LocalFileSystem {
let config = Arc::clone(&config);
maybe_spawn_blocking(move || {
let location = location?;
- Self::delete_location(config, automatic_cleanup,
&location)?;
+ Self::delete_location(config, automatic_cleanup,
&location, false)?;
Review Comment:
WHy doesn't fsync apply to standalone deletes (if we don't fsync isn't there
some chance that a deleted file will get "undeleted" on crash)?
This code is no worse than main so we can merge it in, but I don't fully
understand. This can be a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
