kevinjqliu commented on code in PR #758:
URL:
https://github.com/apache/arrow-rs-object-store/pull/758#discussion_r3436778013
##########
src/local.rs:
##########
@@ -513,7 +513,7 @@ impl ObjectStore for LocalFileSystem {
let config = Arc::clone(&config);
maybe_spawn_blocking(move || {
let location = location?;
- Self::delete_location(config, automatic_cleanup,
&location)?;
+ Self::delete_location(config, automatic_cleanup,
&location, false)?;
Review Comment:
> WHy doesn't fsync apply to standalone deletes (if we don't fsync isn't
there some chance that a deleted file will get "undeleted" on crash)?
it should! but it doesnt right now, the documented mentions only write-like
operations and not deletes
https://github.com/apache/arrow-rs-object-store/blob/c9db3e22d2eed690b7a9c14a988ec85d6b9304ad/src/local.rs#L310-L316
Let's do a follow up to make standalone `delete` / `delete_stream`
crash-durable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
