Copilot commented on code in PR #50451:
URL: https://github.com/apache/arrow/pull/50451#discussion_r3552896039
##########
r/tests/testthat/test-dplyr-funcs-type.R:
##########
@@ -31,7 +31,7 @@ test_that("explicit type conversions with cast()", {
int_types <- c(int8(), int16(), int32(), int64())
uint_types <- c(uint8(), uint16(), uint32(), uint64())
- float_types <- c(float32(), float64())
+ float_types <- c(float16(), float32(), float64())
Review Comment:
Adding `float16()` to `float_types` here expands type-coverage but still
doesn't assert that Float16 values roundtrip back to R correctly (the GH-50378
regression was about decoding values, not just preserving the schema type).
Consider adding a small regression check that casts to `float16()` and then
`collect()`s to ensure the resulting R value matches the input (and is not the
raw uint16 bits).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
